Unicorn approvals #175
Merged
Unicorn approvals #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace in shared namespace definition
…ce to UnicornApprovalsNamespace across multiple templates
…rnApprovals in subscriptions.yaml
…s in dependabot configuration and unit test workflows
…elated handlers and configurations
…7 respectively in GitHub workflows
…o include serverless plugin
…for parity with TypeScript version and workshop description
…v0.3.3" This reverts commit f383b3d.
…ndling publication approval requests and events
…system configuration for Approvals and Contracts
…ionManagerService
|
undefined No related issues found. Please ensure 'pending-release' label is applied before releasing. |
sliedig
added a commit
that referenced
this pull request
Nov 7, 2025
* feat: add command to list the parameters in parameters store * refactor: renamed UnicornPropertiesNamespace to UnicornApprovalsNamespace in shared namespace definition * refactor: updated resolve:ssm references for UnicornPropertiesNamespace to UnicornApprovalsNamespace across multiple templates * refactor: rename unicorn properties to unicorn approvals * refactor: update event bus references from UnicornProperties to UnicornApprovals in subscriptions.yaml * refactor: update references from UnicornProperties to UnicornApprovals in dependabot configuration and unit test workflows * chore: upgrade actions/upload-artifact from v3 to v4 in GitHub workflow * fixed small issues * refactor: rename properties_service to approvals_service and update related handlers and configurations * chore: update Approvals readme * chore: updated contracts readme * chore: update web readme * chore: updated main readme * chore: upgrade actions/checkout and actions/github-script to v4 and v7 respectively in GitHub workflows * chore: update README to reflect new build workflow and correct image tag * chore: add GitHub Actions workflow for building Python services * chore: add ruff installation step to GitHub Actions build workflow * chore: modify GitHub Actions build workflow to use uv run for build and clean steps * chore: upgrade CodeQL action versions to v3 in GitHub workflows * chore: update cfn-lint installation step in GitHub Actions workflow to include serverless plugin * fix: allow cfn-lint command to continue on error in Makefile * some name changes to approvals. Moved example events to other folder for parity with TypeScript version and workshop description * fixing unint tests * downgrade cfn-lint serverless-rules because of an issue with v0.3.3 * Revert "downgrade cfn-lint serverless-rules because of an issue with v0.3.3" This reverts commit f383b3d. * chore: update architecture diagram * refactor: update event source and rule names to use 'unicorn.approvals' * refactor: renames ApprovalService to PublicationManagerService for handling publication approval requests and events * fix: remove error suppression for cfn-lint command. Removed uv build-system configuration for Approvals and Contracts * fix: update import path for request approval function to use PublicationManagerService * chore: minor update to readme file * chore: updated approvals readme * chore: updated bus name in test events * chore: updated readme and spelling mistakes * chore: bumped dependencies * fix: syncing templates --------- Co-authored-by: Marco Buss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This pull request refactors the Unicorn Properties service into Unicorn Approvals service, updating the namespace and service naming throughout the codebase. The main changes include:
Unicorn.PropertiestoUnicorn.Approvalsthroughout the codebaseUnicornPropertiesNamespacetoUnicornApprovalsNamespaceUnicornPropertiesEventBustoUnicornApprovalsEventBusUser experience
Before: The service was named "Unicorn Properties" which could be confusing as it handled approval workflows rather than property management directly.
After: The service is now named "Unicorn Approvals" which more accurately reflects its purpose of handling approval workflows for contracts and properties. This provides better clarity for developers and users about the service's actual functionality.
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.